[Hexagon] Delete offload runtime, move files to right places #11090
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Within
src/runtime/hexagon
android
,hexagon
to.
, deletehexagon
,host/hexagon_module.cc
withhexagon_module.cc
, deletehost
.Rename
HexagonHostModuleNode
toHexagonModuleNode
.Edit:
One additional change in the contents of
HexagonModule
is that the list of functions with the "C packed" ABI is no longer needed and has been removed. Functions that were offloaded to Hexagon could have had any number of parameters, and the interface would be created inside of TVM when the offloaded code was extracted into its own function. Calls to these functions could not be generated by TVM at the same time, because the calls were placed in the host code, and were "remote calls", i.e. were calling the runtime to indicate what functions need to be called on Hexagon. The actual "call" instructions were in the runtime, which needed to know what parameter-passing conventions was used: it would set up parameter register, stack, and execute a branch to the function code. Because of that, the list of functions following the "C packed" convention was also a member of the Hexagon module.With the offload removed, there are no "remote calls" anymore, and the calling conventions are handled internally by LLVM.
cc @mehrdadh