Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hexagon] Delete offload runtime, move files to right places #11090

Merged
merged 1 commit into from
Apr 22, 2022
Merged

[Hexagon] Delete offload runtime, move files to right places #11090

merged 1 commit into from
Apr 22, 2022

Conversation

kparzysz-quic
Copy link
Contributor

@kparzysz-quic kparzysz-quic commented Apr 21, 2022

Within src/runtime/hexagon

  • delete directory android,
  • move files from hexagon to ., delete hexagon,
  • merge host/hexagon_module.cc with hexagon_module.cc, delete host.

Rename HexagonHostModuleNode to HexagonModuleNode.

Edit:
One additional change in the contents of HexagonModule is that the list of functions with the "C packed" ABI is no longer needed and has been removed. Functions that were offloaded to Hexagon could have had any number of parameters, and the interface would be created inside of TVM when the offloaded code was extracted into its own function. Calls to these functions could not be generated by TVM at the same time, because the calls were placed in the host code, and were "remote calls", i.e. were calling the runtime to indicate what functions need to be called on Hexagon. The actual "call" instructions were in the runtime, which needed to know what parameter-passing conventions was used: it would set up parameter register, stack, and execute a branch to the function code. Because of that, the list of functions following the "C packed" convention was also a member of the Hexagon module.
With the offload removed, there are no "remote calls" anymore, and the calling conventions are handled internally by LLVM.

cc @mehrdadh

@mehrdadh
Copy link
Member

@kparzysz-quic this is great!
I think you missed a header file path change.

@mehrdadh
Copy link
Member

@kparzysz-quic can you add notes in the PR description about changes in hexagon codegen for better documentation?

@mehrdadh mehrdadh self-assigned this Apr 21, 2022
@mehrdadh
Copy link
Member

mehrdadh commented Apr 21, 2022

@kparzysz-quic there's a merge conflict which might have been introduced by #11065. Please rebase and then we can merge.

Within src/runtime/hexagon
- delete directory android,
- move files from hexagon to ., delete hexagon,
- merge host/hexagon_module.cc with hexagon_module.cc, delete host.

Rename HexagonHostModuleNode to HexagonModuleNode.
@kparzysz-quic kparzysz-quic merged commit e0e788b into apache:main Apr 22, 2022
@kparzysz-quic kparzysz-quic deleted the hexagon-delete-offload-runtime branch April 22, 2022 15:20
shtinsa pushed a commit to Deelvin/tvm that referenced this pull request May 17, 2022
…11090)

Within src/runtime/hexagon
- delete directory android,
- move files from hexagon to ., delete hexagon,
- merge host/hexagon_module.cc with hexagon_module.cc, delete host.

Rename HexagonHostModuleNode to HexagonModuleNode.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants