[Schedule] Allowed typing.Tuple in tir.schedule._type_checker #11289
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Previously, `typing.Tuple` annotations could not be used with `tir.schedule._type_checker.type_checked` annotations. This allows `Tuple` type annotations to be type-checked.
vinx13
reviewed
May 12, 2022
|
Thanks for improving the type checker! Maybe at some time point we could together propose to lift this to top-level TVM utility with an RFC :-) |
Directly interacting with a type object would otherwise cause some false positives.
Lunderberg
force-pushed
the
type_check_tuple
branch
from
09ecb3f
to
0bb2bbd
Compare
This gives a better error message and plays nicely with _type2str, since `typing.Any` doesn't have a `__name__` field.
|
@vinx13 @junrushao1994 CI passing, and ready for review. |
vinx13
approved these changes
May 20, 2022
Lunderberg
added a commit
to Lunderberg/tvm
that referenced
this pull request
May 20, 2022
Disabled while waiting for apache#11289, which was required for the `Tuple` argument.
vinx13
pushed a commit
that referenced
this pull request
May 26, 2022
* [TIR][Schedule] Added Schedule.transform_layout_sugared * [TE][TIR] Reduced duplication in TE/TIR layout transformations Previously, the implementations of `tir.IndexMap.from_func` and `te.Stage.transform_layout` had significant duplication to handle argument parsing. This commit extracts the shared logic into `tir.IndexMap`. * Enabled *args in Schedule.transform_layout_sugared * Fix lint error * Allow Schedule.transform_layout_sugared to set axis separators * Merged transform_layout_sugared functionality into transform_layout * Fix lint errors * Fix lint error * Fixed docstring errors * Updated/tested TransformatLayoutTraits::UnpackedAsPython * Disabled exec-used check for running trace.as_python() * Updated SetAxisSeparatorTraits::UnpackedAsPython * Updated unit test that was added in merge commit * Fixed the argument name for TensorizeTraits This wasn't checked before, but was the only other issue caught by the updates to verify_trace_roundtrip. * Re-enable type checks of transform_layout/set_axis_separator Disabled while waiting for #11289, which was required for the `Tuple` argument. * Updated a few additional transform_layout usages from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously,
typing.Tupleannotations could not be used withtir.schedule._type_checker.type_checkedannotations. This allowsTupletype annotations to be type-checked.