Finish support for list-of-targets #11382
Merged
Commits on May 22, 2022
-
Finish support for list-of-targets
This finishes the work started in apache#11173 to support 'external codegen' targets in the N build-like API surfaces. - It turns out it's ok if a build is given only a single 'external codegen' target, so remove that check in CompilationConfig::Init. When Collage builds a 'candidate partition' it does so for a single target. As far as Collage is concerned it does not care whether the target is regular (eg Target("cuda")), or for a specific external codegen (eg Target("cutlass")), it just passes the target into the build. - Add CompilationConfig::FindPrimitiveTargetForKind which I'll later need to retrieve the external codegen Target instance corresponding to a "Compiler" attribute value. - Target.update_target_host_consist was supporting three API styles: - single target - map from device type to target - map from target to IRModule (for the ir_to_runtime API) I replaced all those calls with a more specialized 'canonicalize' call: - Target.canonicalize_target_and_host - Target.canonicalize_multi_targets_and_host - Target.canonicalize_target_map_and_host In particular, all the tuning interfaces (task extraction, tuning, tuning records) all explicitly *do not* support multiple targets since the underlying code just doesn't support that.
-
-
- Fix model_library_format handling of target.
- Improve comments in compilation_config.h
-
- Fix micro library format tests
- Rev micro library format from 5 to 6 - Use Target.current() in a few places
-
-
- Woops, one more device: target map left
- Handle host already being in Target
-
-
-
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.