Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Tests] Replace the Relay interpreter with the VM in the op tests #11386

Merged
merged 1 commit into from
May 23, 2022

Conversation

gigiblender
Copy link
Contributor

This PR disables, if possible, the Relay interpreter in the op level tests and enables the VM instead. It also parameterizes some of the tests to switch easily between the interpreter and other executors when further support is provided.

@areusch

@areusch
Copy link
Contributor

areusch commented May 20, 2022

@mbs-octoml @altanh can you take a look?

Copy link
Contributor

@mbs-octoml mbs-octoml left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

In case you're wondering, the weird idiom in these tests where the create_executor / evaluate / apply phases are all brought together is because the create_executor phase supports including an IRModule who's definitions should be 'visible' to the evaluate expression. However in practice all that happens is the IRModule and expression to be evaluated are joined together and compiled as a unit. Thus we should probably collapse the create_executor and evaluate phases, and the code was reworked to make that job easier in the future.

@gigiblender
Copy link
Contributor Author

Thanks for the explanation @mbs-octoml.

I can see that for some reason even though you approved the changes, the PR wasn't merged automatically.

@masahi masahi merged commit df632ba into apache:main May 23, 2022
@masahi
Copy link
Member

masahi commented May 23, 2022

@gigiblender Approving and merging need separate actions (anyone can approve, but only a committer can merge).

@gigiblender
Copy link
Contributor Author

Thanks for the clarification @masahi.

@gigiblender gigiblender deleted the relay-op-tests branch May 23, 2022 10:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants