Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay] Finish implementations of WithFields #11674

Merged
merged 5 commits into from
Jun 11, 2022

Conversation

mbs-octoml
Copy link
Contributor

This has been sitting in my collage branch forever, might as well clear it into main.

I added the beginnings of a unit test, but only for the Call overload.

Copy link
Member

@Mousius Mousius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yay! Consistency! Just needs a few more tests and this LGTM @mbs-octoml

src/relay/ir/expr.cc Show resolved Hide resolved
@Mousius Mousius self-assigned this Jun 11, 2022
This has been sitting in my collage branch forever, might as well clear it into main.

I added the beginnings of a unit test, but only for the Call overload.
@mbs-octoml
Copy link
Contributor Author

mbs-octoml commented Jun 11, 2022

Looks like #11631 and #11513 clashed, so I'm going to include the trivial fix as a rider in this PR.

@mbs-octoml
Copy link
Contributor Author

Thanks @Mousius, pls merge when you get a chance.

@Mousius Mousius merged commit 8f6543e into apache:main Jun 11, 2022
@mbs-octoml mbs-octoml deleted the mbs-collage-withfields branch June 12, 2022 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants