-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ETHOSN] Upgrade NPU driver stack to v22.05 #11759
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@tvm-bot rerun |
65df115
to
67d18dc
Compare
@tvm-bot rerun |
friendly ping for review. also cc @manupa-arm @leandron |
friendly ping for review |
manupak
approved these changes
Jul 27, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
In updating the driver stack to v22.05 some additional things needed changes: * Prevent split being offloaded to the NPU which is not supported in v22.05. * Removes compile algorithm configuration option since this was removed in v22.05. Versions before v22.05 will use the default option. * Managing some API changes. * Updating network compile hashes. * Updating expected error message for overall scale bounds check. Change-Id: I09343c398a1f47dec44e135ff8252a6315a9b63f
Change-Id: Ib1a34093b4011bdc20fca47d474eb1786218de98
For some reason PyTest evaluates the second skipif decorator even if the first one marks the test to be skipped. Thus, meaning test collection fails when we want to check the version. The workaround is to return None when the version is not available. Change-Id: I7cdd8cc70a9ee3c193e9a900f1011829538d975b
Change-Id: I7555c4a4d7db4f6c7aa8d476e39277fc5cba2f0d
Thanks @manupa-arm! |
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
* [ETHOSN] Upgrade NPU driver stack to v22.05 In updating the driver stack to v22.05 some additional things needed changes: * Prevent split being offloaded to the NPU which is not supported in v22.05. * Removes compile algorithm configuration option since this was removed in v22.05. Versions before v22.05 will use the default option. * Managing some API changes. * Updating network compile hashes. * Updating expected error message for overall scale bounds check. Change-Id: I09343c398a1f47dec44e135ff8252a6315a9b63f * fix decorator evaluation order Change-Id: Ib1a34093b4011bdc20fca47d474eb1786218de98 * Return none if version doesn't exist For some reason PyTest evaluates the second skipif decorator even if the first one marks the test to be skipped. Thus, meaning test collection fails when we want to check the version. The workaround is to return None when the version is not available. Change-Id: I7cdd8cc70a9ee3c193e9a900f1011829538d975b * Update resnet hash after rebase Change-Id: I7555c4a4d7db4f6c7aa8d476e39277fc5cba2f0d
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In updating the driver stack to v22.05 some additional things needed changes:
v22.05.
in v22.05. Versions before v22.05 will use the default option.
cc @Leo-arm