[fix] MXNet dot for all tensor dimensions #11760
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Any feedback about this PR? |
|
I think this PR is correct now. The problem was trivial about the structure of the code that lint tests suggested. Please, take a look now if you can. |
areusch
added
needs-triage
masahi
approved these changes
Jan 1, 2023
fzi-peccia
pushed a commit
to fzi-peccia/tvm
that referenced
this pull request
Mar 27, 2023
* [fix] MXNet dot for all tensor dimensions * Fixing the MxNet structure
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR problem of MXNet dot for all tensor dimensions is fixed. This PR is related to #11691 issue.
Previously, it was only provided the case of 2D tensors, but not 1D and non 2D tensors and their combinations.
This is provided now.