set FLUSH_TO_ZERO ON by default #11906
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkonolige
reviewed
Jun 27, 2022
There was a problem hiding this comment.
I'm not that experienced with flush to zero. @AndrewZhaoLuo I know has done some experiments with it. Maybe he could comment.
Also, if this is a large change, the best way to get some discussion on this would be to submit a RFC to tvm-rfcs (https://github.com/apache/tvm-rfcs).
Comment on lines
+58
to
+64
| if (target->kind->name == "llvm" && !(_mm_getcsr() & 0x8040)) { | ||
| LOG(WARNING) << "Set FLUSH_TO_ZERO ON by default in Build on LLVM."<< std::endl; | ||
| //DAZ | ||
| _mm_setcsr( _mm_getcsr() | 0x0040 ); | ||
| //FTZ | ||
| _mm_setcsr( _mm_getcsr() | 0x8000 ); | ||
| } |
There was a problem hiding this comment.
Seems like this should be in the runtime not the build. What happens if someone builds remotely and then uploads the compiled artifact? Seems like flush to zero would not be changed.
There was a problem hiding this comment.
Is this portable? Also can we just leverage LLVM through like a flag or something like #9223?
areusch
added
needs-triage
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR aims to start a discussion on how to enable a
set_flush_to_zerointerface that is user friendly.(The initial solution is provided.)
The interface is supposed to meet the following requirements: