-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ETHOSN] Supply output tensor to issupported checks #11944
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
74a28f5
to
f55d704
Compare
leo-blonk
approved these changes
Jun 30, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
f55d704
to
ee8e719
Compare
@tvm-bot rerun |
1 similar comment
@tvm-bot rerun |
Some operations were being offloaded when they are not supported by the NPU, for example mean could get offloaded with different quantization parameters for the input and output which is not supported. Consequently, this meant that there would be a failure during compilation or an output mismatch at runtime. Fixing this by supplying the output information to the issupported checks that determine whether an operation should be offloaded. Change-Id: I8896f83dad3d1c837fbb85bf2836fc9325f9dec9
friendly ping |
manupak
approved these changes
Jul 21, 2022
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM!
Thanks! @lhutton1 @Leo-arm! |
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
Some operations were being offloaded when they are not supported by the NPU, for example mean could get offloaded with different quantization parameters for the input and output which is not supported. Consequently, this meant that there would be a failure during compilation or an output mismatch at runtime. Fixing this by supplying the output information to the issupported checks that determine whether an operation should be offloaded. Change-Id: I8896f83dad3d1c837fbb85bf2836fc9325f9dec9
mikeseven
pushed a commit
to mikeseven/tvm
that referenced
this pull request
Sep 27, 2023
Some operations were being offloaded when they are not supported by the NPU, for example mean could get offloaded with different quantization parameters for the input and output which is not supported. Consequently, this meant that there would be a failure during compilation or an output mismatch at runtime. Fixing this by supplying the output information to the issupported checks that determine whether an operation should be offloaded. Change-Id: I8896f83dad3d1c837fbb85bf2836fc9325f9dec9
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some operations were being offloaded when they are not supported by the NPU, for example mean could get offloaded with different quantization parameters for the input and output which is not supported. Consequently, this meant that there would be a failure during compilation or an output mismatch at runtime. Fixing this by supplying the output information to the issupported checks that determine whether an operation should be offloaded.
cc @Leo-arm @manupa-arm