Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[ETHOSN] Supply output tensor to issupported checks #11944

Merged
merged 1 commit into from
Jul 21, 2022

Conversation

lhutton1
Copy link
Contributor

Some operations were being offloaded when they are not supported by the NPU, for example mean could get offloaded with different quantization parameters for the input and output which is not supported. Consequently, this meant that there would be a failure during compilation or an output mismatch at runtime. Fixing this by supplying the output information to the issupported checks that determine whether an operation should be offloaded.

cc @Leo-arm @manupa-arm

@github-actions github-actions bot requested a review from manupak June 29, 2022 09:52
Copy link
Contributor

@leo-blonk leo-blonk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lhutton1
Copy link
Contributor Author

@tvm-bot rerun

1 similar comment
@lhutton1
Copy link
Contributor Author

@tvm-bot rerun

Some operations were being offloaded when they are not supported
by the NPU, for example mean could get offloaded with different
quantization parameters for the input and output which is not
supported. Consequently, this meant that there would be a failure
during compilation or an output mismatch at runtime. Fixing this by
supplying the output information to the issupported checks that
determine whether an operation should be offloaded.

Change-Id: I8896f83dad3d1c837fbb85bf2836fc9325f9dec9
@lhutton1
Copy link
Contributor Author

lhutton1 commented Jul 8, 2022

friendly ping

Copy link
Contributor

@manupak manupak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@manupak manupak merged commit 4fc79b5 into apache:main Jul 21, 2022
@manupak
Copy link
Contributor

manupak commented Jul 21, 2022

Thanks! @lhutton1 @Leo-arm!

@lhutton1 lhutton1 deleted the fix-issupported branch July 21, 2022 15:40
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
Some operations were being offloaded when they are not supported
by the NPU, for example mean could get offloaded with different
quantization parameters for the input and output which is not
supported. Consequently, this meant that there would be a failure
during compilation or an output mismatch at runtime. Fixing this by
supplying the output information to the issupported checks that
determine whether an operation should be offloaded.

Change-Id: I8896f83dad3d1c837fbb85bf2836fc9325f9dec9
mikeseven pushed a commit to mikeseven/tvm that referenced this pull request Sep 27, 2023
Some operations were being offloaded when they are not supported
by the NPU, for example mean could get offloaded with different
quantization parameters for the input and output which is not
supported. Consequently, this meant that there would be a failure
during compilation or an output mismatch at runtime. Fixing this by
supplying the output information to the issupported checks that
determine whether an operation should be offloaded.

Change-Id: I8896f83dad3d1c837fbb85bf2836fc9325f9dec9
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants