Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Cleanup after renaming ci_qemu #12329

Merged
merged 1 commit into from
Aug 8, 2022

Conversation

mehrdadh
Copy link
Member

@mehrdadh mehrdadh commented Aug 5, 2022

@mehrdadh
Copy link
Member Author

mehrdadh commented Aug 5, 2022

#fixes #12280

@github-actions github-actions bot requested review from Mousius and areusch August 5, 2022 21:22
@leandron
Copy link
Contributor

leandron commented Aug 8, 2022

Ideally this needs a better commit message than cleanup to say exactly what it is doing (given files are being deleted, for example). So I'm rephrasing it as I'm merging their PR.

@leandron leandron merged commit 8e133b1 into apache:main Aug 8, 2022
@driazati
Copy link
Member

driazati commented Aug 8, 2022

Ideally this needs a better commit message than cleanup to say exactly what it is doing (given files are being deleted, for example). So I'm rephrasing it as I'm merging their PR.

thanks @leandron, given https://discuss.tvm.apache.org/t/rfc-v2-commit-message-guideline/13249/3?u=driazati I think this should become common practice to at least copy-paste in the PR body

@mehrdadh mehrdadh deleted the micro/rename_qemu_cleanup branch August 8, 2022 17:03
xinetzone pushed a commit to daobook/tvm that referenced this pull request Nov 25, 2022
….ci_cortexm (apache#12329)

Removes the - now deprecated - Dockerfile.ci_qemu, as it was moved to be specialized in different environments such as Dockerfile.ci_cortexm, to support specific environments for tests in different platforms.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Tracking Issue] Rename ci_qemu to ci_cortexm
3 participants