[TIR, TVMScript] Update printer / parser to make T.allocate return buffer var #12412
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
vinx13
force-pushed
the
feat/decl-buffer-1-tvmscript
branch
from
628b844 to
f2a0a1a
Compare
4 tasks
vinx13
force-pushed
the
feat/decl-buffer-1-tvmscript
branch
8 times, most recently
from
1f07d88 to
45a5ac8
Compare
Lunderberg
reviewed
Aug 30, 2022
| @@ -100,13 +100,21 @@ class BufferUsageFinder : public StmtExprVisitor { | |||
| StmtExprVisitor::VisitStmt_(op); | |||
| } | |||
|
|
|||
| void VisitStmt_(const DeclBufferNode* op) final { | |||
| buffers_declared_.insert(op->buffer.get()); | |||
There was a problem hiding this comment.
Should we also track which buffers have gone out of scope? If I'm understanding it correctly, a single DeclBufferNode would also allow for usage outside of the DeclBufferNode::body, where I'd expect it to only apply within the scope of the node.
tests/python/contrib/test_ethosu/test_copy_compute_reordering.py
Outdated
Show resolved
Hide resolved
vinx13
commented
Aug 30, 2022
There was a problem hiding this comment.
To answer the question about T.allocate vs T.decl_buffer update:
There are two ways to update the existing TVM scripts.
- Update
T.allocatetoT.allocate+T.buffer_decl. This is strictly equivalent to the TIR before. - Update
T.allocatetoT.allocate+T.decl_buffer, (or the syntax sugar form, only a singleT.decl_bufferstatement without data argument). This adds aDeclBuffernode in TIR, which is not strictly equivalent to the TIR before. This is the preferred way (as it uses explicitDeclBuffer) but might require updating the existing passes. To minimize changes to existing passes in this PR, in the case this method doesn't work out-of-box, we will choose method 1 for now.
|
That makes sense for minimizing the changes to the generated TIR, so that those can be handled in an independent change. Marking all of those conversations as resolved. |
vinx13
force-pushed
the
feat/decl-buffer-1-tvmscript
branch
from
45a5ac8 to
071b81d
Compare
xinetzone
pushed a commit
to daobook/tvm
that referenced
this pull request
Nov 25, 2022
…ffer var (apache#12412) * Updated TVMScript syntax of `T.allocate` to return buffer var. * Added syntax sugar for `T.decl_buffer`. When `data` field is not specified, `data` will be implicitly created via `Allocate` stmt. * Updated the existing test cases. Most test cases can be updated by changing `T.allocate` to `T.decl_buffer`. `T.allocate` in some tests are updated to `T.allocate` + `T.buffer_decl`, to maintain the legacy behavior of allocation and implicit buffer declaration (will be followed up in future PR to adopt `T.decl_buffer`).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
T.allocateto return buffer var.T.decl_buffer. Whendatafield is not specified,datawill be implicitly created viaAllocatestmt.T.allocatetoT.decl_buffer.T.allocatein some tests are updated toT.allocate+T.buffer_decl, to maintain the legacy behavior of allocation and implicit buffer declaration (will be followed up in future PR to adoptT.decl_buffer).Related RFC: apache/tvm-rfcs#87
cc @junrushao1994 @Lunderberg @wrongtest-intellif @cyx-6 @tqchen