Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Build] Expose missing USE_VERILATOR in cmake #13676

Merged
merged 1 commit into from
Jan 1, 2023
Merged

[Build] Expose missing USE_VERILATOR in cmake #13676

merged 1 commit into from
Jan 1, 2023

Conversation

cbalint13
Copy link
Contributor

@cbalint13 cbalint13 commented Dec 30, 2022

This PR updates cmake exposure of USE_VERILATOR flag for the verilator contrib module.

Fixes the following:

  • Proper appearance in cmake option list
  • Proper display in cmake post summary of configuration

Does not change current behaviour, USE_VERILATOR remains OFF by default.


Here is the USE_VERILATOR visibility:

/usr/bin/cmake {...} -DUSE_VERILATOR=ON
{...}
--   ---------------- Summary ----------------
--   CMake version         : 3.25.1
--   CMake executable      : /usr/bin/cmake
{...}
--    USE_VERILATOR                      : ON
--    USE_VITIS_AI                       : OFF
--    USE_VULKAN                         : OFF
-- Configuring done
-- Generating done

Cc @areusch , @tmoreau89 , @vegaluisjose please help with the review.

Thanks,
~Cristian.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Dec 30, 2022

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: build See #10317 for details

Generated by tvm-bot

@cbalint13 cbalint13 changed the title Expose missing USE_VERILATOR in cmake [Build] Expose missing USE_VERILATOR in cmake Dec 30, 2022
@masahi masahi merged commit fba9165 into apache:main Jan 1, 2023
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants