[Fix,TOPI] Consolidate generic and x86 scatter nd #13755
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
The generic scatter nd was almost identical to the x86 one and was not tested. They now are one and the same.
tkonolige
force-pushed
the
fix_scatter_nd
branch
from
f83ef07
to
97354cd
Compare
AndrewZhaoLuo
approved these changes
Jan 11, 2023
| @@ -268,63 +268,58 @@ def scatter_nd(data, indices, updates, mode): | |||
| _verify_scatter_nd_inputs(data, indices, updates) | |||
|
|
|||
| def gen_ir(data_ptr, indices_ptr, updates_ptr, out_ptr): | |||
| # pylint: disable=invalid-name | |||
There was a problem hiding this comment.
nit: just give it a good name
There was a problem hiding this comment.
This is from the old code.
There was a problem hiding this comment.
can you fix it while you are here, small change
fzi-peccia
pushed a commit
to fzi-peccia/tvm
that referenced
this pull request
Mar 27, 2023
The generic scatter nd was almost identical to the x86 one and was not tested. They now are one and the same.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The generic scatter nd was almost identical to the x86 one and was not tested. They now are one and the same.
@AndrewZhaoLuo