-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CMSIS-NN] Remove support for the old CMSIS NN project #13760
[CMSIS-NN] Remove support for the old CMSIS NN project #13760
Conversation
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
I'm gonna update the docker image to 20.04 once this is merged: |
You need to update the image as well, otherwise it doesn't pass the tests. You can use this image that I just pushed Also, to actually test the PR you need to also commit this to a TVM branch. Let me know if you don't have access and I will do it. |
@ashutosh-arm I don't think we need #13762 to merge this. Because Zephyr project API checks for dependency to CMSIS_NN and if the project is not dependent it doesn't need to add CMSIS_NN to generated project |
Also we could separate updating the image from this PR, I think that should be fine as well |
#13764 is updating the image. |
Pr: apache#13656 adds support for the new CMSIS NN project Change-Id: I28e99fd511b42d9a77ebc6bdc085fc5ffc6b533a
af54251
to
c7be7cb
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @NicolaLancellotti. LGTM!
I rebased the pr, and CI is now green. |
Pr: apache#13656 adds support for the new CMSIS NN project After the docker image is updated we can remove support for the old CMSIS NN project.
Pr: #13656 adds support for the new CMSIS NN project
After the docker image is updated we can remove support for the old CMSIS NN project.