[TIR][Fix] Buffer slicing using index dtype as extent #13788
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
MasterJH5574
changed the title
MasterJH5574
force-pushed
the
tvm-dev/2023-01-15-tir-parser-extent
branch
from
f7e7528
to
84a9f8c
Compare
cyx-6
approved these changes
Jan 15, 2023
junrushao
approved these changes
Jan 16, 2023
@junrushao Sorry my bad. I didn’t notice that... Will do later. |
MasterJH5574
force-pushed
the
tvm-dev/2023-01-15-tir-parser-extent
branch
from
84a9f8c
to
f951dcc
Compare
junrushao
changed the title
Hzfengsy
reviewed
Jan 16, 2023
| test_different_dtype_assignment_to_var() | ||
| b = 1 | ||
| test_var_capturing_order() | ||
| tvm.testing.main() |
There was a problem hiding this comment.
a = numpy.zeros((10, 10), dtype="int8") here is to test var capturing in #13640. I appreciate it if you could revert it and add a comment here.
fzi-peccia
pushed a commit
to fzi-peccia/tvm
that referenced
this pull request
Mar 27, 2023
[Fix] Buffer slicing using index dtype as extent
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a bug of TIR Buffer
__getitem__on Python side.Whenever the
__getitem__parameter is a multi-dim slice, on non-slice dimension a Range will be created. Prior to this PR, that range will have int32 dtype in regardless of thestart, while the proper behavior is to generate the extent according to the dtype ofstartwhenstartis a PrimExpr.This PR fixes the issue and provides a regression test.