Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TESTING] Enable execution of test_packed_8x8x32_resnet50 #13799

Merged
merged 4 commits into from
Jan 20, 2023

Conversation

abhikran-quic
Copy link
Contributor

@abhikran-quic abhikran-quic commented Jan 17, 2023

PR #13792 fixes bug in cache_write. Resnet 50 is passing now with custom schedule.
Adding below mentioned changes as well for test to pass.

  • Add condition for IndexMap
  • Add empty dict while calling tune_conv2d_template to avoid failure

CC: @masahi @csullivan

Resnet 50 is passing now. Need to add below mentioned changes as well for test to pass.

- Add condition for IndexMap
- Add empty dict while calling tune_conv2d_template to avoid failure
@tvm-bot
Copy link
Collaborator

tvm-bot commented Jan 17, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

  • No users to tag found in teams: testing See #10317 for details

Generated by tvm-bot

@abhikran-quic
Copy link
Contributor Author

Hi @csullivan @masahi - Could you please help in reviewing this PR ?

@masahi masahi merged commit 8f738d0 into apache:main Jan 20, 2023
@abhikran-quic abhikran-quic deleted the fix_resnet_test branch January 20, 2023 11:04
@abhikran-quic
Copy link
Contributor Author

Thank you @masahi!

fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
* [TESTING] Enable execution of test_packed_8x8x32_resnet50
Resnet 50 is passing now. Need to add below mentioned changes as well for test to pass.

- Add condition for IndexMap
- Add empty dict while calling tune_conv2d_template to avoid failure

* Fix unused variable error

* Remove unused variable and change check in if condition
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants