Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[microTVM][CRT]Separate CRT template project from standalone CRT build #13812

Merged
merged 4 commits into from
Jan 23, 2023

Conversation

mehrdadh
Copy link
Member

@mehrdadh mehrdadh commented Jan 20, 2023

This PR separates the CRT template project for microTVM from CRT standalone library build. The CRT template project would move to build/microtvm_template_projects.

It also adds uploading microtvm_template_projects to S3 in few images that were missing this previously.

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jan 20, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@mehrdadh
Copy link
Member Author

@tvm-bot rerun

@mehrdadh mehrdadh changed the title [Draft][microTVM][CRT]Separate CRT template project from standalone CRT build [microTVM][CRT]Separate CRT template project from standalone CRT build Jan 20, 2023
@mehrdadh mehrdadh marked this pull request as ready for review January 20, 2023 20:08
@mehrdadh
Copy link
Member Author

cc @alanmacd for review

Copy link
Contributor

@alanmacd alanmacd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehrdadh mehrdadh merged commit b77d24c into apache:main Jan 23, 2023
@mehrdadh mehrdadh deleted the micro/move_crt_project_template branch January 23, 2023 18:12
mehrdadh added a commit that referenced this pull request Feb 13, 2023
…mplate.c (#13885)

This PR refactors all the necessary functions for a CRT project into platform-template.c file

In addition, these templates files are also added along with crt_config-template.h (which was accidentally removed in #13812) to generated model library format (MLF). Here is the updated structure of a MLF file:

.
├── codegen
│   └── host
├── metadata.json
├── parameters
│   └── default.params
├── runtime
│   ├── include
│   ├── Makefile
│   └── src
├── src
│   └── default.relay
└── templates
    ├── crt_config-template.h
    ├── platform-template.c
fzi-peccia pushed a commit to fzi-peccia/tvm that referenced this pull request Mar 27, 2023
apache#13812)

This PR separates the CRT template project for microTVM from CRT standalone library build. The CRT template project would move to build/microtvm_template_projects.

It also adds uploading microtvm_template_projects to S3 in few images that were missing this previously.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants