[Relay] Convert negative axes to positive when importing ONNX Unsqueeze #13846
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, ONNX frontend imports Unsqueeze as a sequence of expand_dims in Relay. This works fine when the axes are positive.
However, for negative axes we need to compute the output rank and add the negative axis value to get its equivalent positive axis value.
This commit computes the output rank as the sum of the input rank of data and the number of axis in the axes array and convert negative axes to positive.
This commit also adds testcases for unsqueeze with negative axes and verifies the result with onnx runtime.