[MetaSchedule] Fix for RewriteLayout + AllocateConst when the rank of the rewritten weight doesn't change #13851
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
the rewritten weight doesn't change
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Hzfengsy
approved these changes
Jan 27, 2023
csullivan
pushed a commit
to csullivan/tvm
that referenced
this pull request
Feb 7, 2023
… the rewritten weight doesn't change (apache#13851) [MetaSchedule] Fix for RewriteLayout + AllocateConst when the rank of the rewritten weight doesn't change
fzi-peccia
pushed a commit
to fzi-peccia/tvm
that referenced
this pull request
Mar 27, 2023
… the rewritten weight doesn't change (apache#13851) [MetaSchedule] Fix for RewriteLayout + AllocateConst when the rank of the rewritten weight doesn't change
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Previously, the condition
constant.Shape().size() == index_map->initial_indices.size()was used to decide if the constant thatTECompilerfinds has its layout write already applied or not. But for 1x1 conv2d case, there seems to be a case where the rank of the weight doesn't change after layout rewriting. For example, (1, 1, 32, 16) -> (16, 4, 2, 4).This bug led to the same index map being applied twice on a constant during MS tuning and the final compilation.