[CRT] USE CMake for CRT standalone libraries #14025
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
mehrdadh
force-pushed
the
crt/add_cmake_for_libs
branch
from
a41b10a
to
3843568
Compare
mehrdadh
changed the title
driazati
approved these changes
Feb 21, 2023
mehrdadh
force-pushed
the
crt/add_cmake_for_libs
branch
from
5b36d4d
to
6f47073
Compare
yongwww
pushed a commit
to yongwww/tvm
that referenced
this pull request
Feb 27, 2023
This PR converts Makefile for standalone CRT libraries to a CMake file which is usable in template projects. After this PR we no longer need to have custom CMake scripts to build CRT standalone libraries but instead just include CMakeLists.txt file that is copied in the CRT lib and link the libraries. Also changed apps/bundle_deploy/Makefile which was a result of this change.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts Makefile for standalone CRT libraries to a CMake file which is usable in template projects. After this PR we no longer need to have custom CMake scripts to build CRT standalone libraries but instead just include CMakeLists.txt file that is copied in the CRT lib and link the libraries.
Also changed apps/bundle_deploy/Makefile which was a result of this change.