-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Bugfix] Conv3Dtranspose default kernel layout should be IODHW #14340
Conversation
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
Can you look at the failed test? |
SInce this PR corrects the conv3d transpose kernel layout, many frontend relay converters and test cases have to be fixed as well. For example, the below test case intentionally set wrong kernel_layout to fit in original wrong kernel layout implementation. tvm/tests/python/contrib/test_dnnl.py Lines 479 to 490 in 46fb2ff
I’ve fixed pytorch relay converter and some test cases, but I would greatly appreciate any assistance with fix. |
a7245d6
to
391e344
Compare
cc @apeskov , this PR is the one you commented as TODO
|
@rebel-jangys Thanks for your hard work, it's merged finally! |
Fix the issue #14326
@masahi