-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[TIR] Add merge primitive for TIR schedule #14398
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.
Generated by tvm-bot |
yincs-intellif
force-pushed
the
main
branch
5 times, most recently
from
March 27, 2023 01:19
7b9124b
to
2c1bb3d
Compare
wrongtest-intellif
requested changes
Mar 28, 2023
yincs-intellif
requested review from
wrongtest-intellif
and removed request for
Hzfengsy
March 28, 2023 06:38
@tvm-bot rerun |
1 similar comment
@tvm-bot rerun |
wrongtest-intellif
approved these changes
Mar 29, 2023
@Hzfengsy Hi Siyuan, please help review this PR. Thanks very much! |
@tvm-bot rerun |
Hzfengsy
requested changes
Mar 30, 2023
Hzfengsy
approved these changes
Apr 3, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
During NPU schedule, we usually encounter multiple out graphs and need do loop partition on each out then compute at other block to the different out block. But current "compute_at" primitive can't handle it.
This PR add "merge" schedule primitive to merge different loops, when cut same tiles on different out blocks by "split" primitive, we can merge these out block under an outer loop, then other blocks can "compute_at" this loop normally.
cc @Hzfengsy @wrongtest-intellif