Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIR] Output DeclBuffer in LowerTVMBuiltin #15243

Merged
merged 2 commits into from
Jul 7, 2023
Merged

[TIR] Output DeclBuffer in LowerTVMBuiltin #15243

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
19b38f3
[TIR] Output DeclBuffer in LowerTVMBuiltin
Lunderberg May 5, 2023
c020de2
Updated LowerTVMBuiltin tests for DeclBuffer
Lunderberg May 9, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/tir/transforms/lower_tvm_builtin.cc
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -145,6 +145,7 @@ class BuiltinLower : public StmtExprMutator {
if (scope.max_sizes.shape_stack != -1) {
scope.stack_shape = decl_buffer({IntImm(DataType::Int(64), scope.max_sizes.shape_stack)},
DataType::Int(64), "stack_shape");
stmt = DeclBuffer(scope.stack_shape, stmt);
stmt = LetStmt(scope.stack_shape->data, StackAlloca("shape", scope.max_sizes.shape_stack),
stmt);
}
Expand All @@ -159,6 +160,7 @@ class BuiltinLower : public StmtExprMutator {
stmt =
LetStmt(scope.stack_value, StackAlloca("arg_value", scope.max_sizes.arg_stack), stmt);

stmt = DeclBuffer(scope.stack_tcode, stmt);
stmt = LetStmt(scope.stack_tcode->data, StackAlloca("arg_tcode", scope.max_sizes.arg_stack),
stmt);
}
Expand Down
6 changes: 4 additions & 2 deletions tests/python/unittest/test_tir_transform_lower_tvm_builtin.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -71,7 +71,9 @@ def check_packed_func(target="llvm"):

# Recursively visit PrimFunc until we meet the for-loop:
while True:
if isinstance(node, (tvm.tir.AssertStmt, tvm.tir.LetStmt, tvm.tir.AttrStmt)):
if isinstance(
node, (tvm.tir.AssertStmt, tvm.tir.LetStmt, tvm.tir.AttrStmt, tvm.tir.DeclBuffer)
):
node = node.body
elif isinstance(node, tvm.tir.SeqStmt):
node = node[0]
Expand All @@ -98,7 +100,7 @@ def check_packed_func(target="llvm"):
#
# let stack_value = tir.tvm_stack_alloca("arg_value", 4)
#
alloca_value = alloca_tcode.body
alloca_value = alloca_tcode.body.body
assert isinstance(alloca_value, tvm.tir.LetStmt)

expected_value = tvm.tir.call_intrin(
Expand Down