Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Hexagon] Propagate QNN Concat Quantization Params to Inputs #15258

Merged
merged 4 commits into from
Jul 10, 2023

Conversation

arangasa
Copy link
Contributor

@arangasa arangasa commented Jul 7, 2023

This helps in using optimized implementations of concat; this PR also avoids redundant requantization when an input to a concat is already a requantize op.

…ting redundant requantization when possible, and make it concat
@tvm-bot
Copy link
Collaborator

tvm-bot commented Jul 7, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@arangasa
Copy link
Contributor Author

arangasa commented Jul 7, 2023

cc @kparzysz-quic @quic-sanirudh

@arangasa arangasa changed the title [Hexagon] Propagate qnn.concat quantization params to inputs, elimina… [Hexagon] Propagate QNN Concat Quantization Params to Inputs Jul 7, 2023
@arangasa arangasa force-pushed the PropQuantParamOfQNNConcat branch from 66eecf8 to faf5854 Compare July 7, 2023 09:40
Copy link
Contributor

@quic-sanirudh quic-sanirudh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM apart from a minor comment.

python/tvm/contrib/hexagon/transform.py Outdated Show resolved Hide resolved
@quic-sanirudh
Copy link
Contributor

@tvm-bot rerun

@quic-sanirudh quic-sanirudh merged commit dc7125b into apache:main Jul 10, 2023
junrushao pushed a commit to junrushao/tvm that referenced this pull request Jul 24, 2023
…15258)

* [Hexagon] Propagate qnn.concat quantization params to inputs, eliminating redundant requantization when possible, and make it concat

* Fix pylint issue

* Add relay IR snippet before and after transformation

* Better test file description comment
junrushao pushed a commit to junrushao/tvm that referenced this pull request Jul 27, 2023
…15258)

* [Hexagon] Propagate qnn.concat quantization params to inputs, eliminating redundant requantization when possible, and make it concat

* Fix pylint issue

* Add relay IR snippet before and after transformation

* Better test file description comment
junrushao pushed a commit to junrushao/tvm that referenced this pull request Jul 30, 2023
…15258)

* [Hexagon] Propagate qnn.concat quantization params to inputs, eliminating redundant requantization when possible, and make it concat

* Fix pylint issue

* Add relay IR snippet before and after transformation

* Better test file description comment
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants