Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI] Pin cython version to fix cython compilation #15353

Merged
merged 1 commit into from
Jul 19, 2023

Conversation

lhutton1
Copy link
Contributor

@lhutton1 lhutton1 commented Jul 18, 2023

Cython 3.0.0 was recently released, but it is incompatible with the current .pxi definitions in python/tvm/_ffi/_cpython. Pinning the cython version until a working fix is created.

Posting this PR as an alternative to #15346.

Cython 3.0.0 was recently released, but it is incompatible with the
current .pxi definitions in python/tvm/_ffi/_python. Pinning
the cython version until a working fix is created.

Posting this PR as an alternative to
apache#15346.

Change-Id: Id817aea375e1ed84c807c265ca4cc42c1757bca0
@tvm-bot
Copy link
Collaborator

tvm-bot commented Jul 18, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

Copy link
Member

@Mousius Mousius left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This seems sensible given updating in Conda likely requires a bit of effort

@tqchen
Copy link
Member

tqchen commented Jul 18, 2023

I think it is better to see if we can get #15346 through, we could remove 3.7 requirement from the conda there

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Instead of pinning package to a lower version, we might want to fix this particular issue instead to get consistent CI vs user/developer-end behavior

@Mousius Mousius dismissed junrushao’s stale review July 19, 2023 12:14

We tried, we couldn't make it work, preference is not to block this PR which fixes the immediate issue.

@Mousius
Copy link
Member

Mousius commented Jul 19, 2023

@tqchen / @junrushao in an ideal world, we would fix everything. As you can see from #15346, it's not straightforward due to how neglected Conda is. I will merge this to resolve the issue and get things back into a stable state; if you can correct Conda and update Cython, that'd be great, we lack the expertise in this area 😸

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants