-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[CI] Pin cython version to fix cython compilation #15353
Conversation
Cython 3.0.0 was recently released, but it is incompatible with the current .pxi definitions in python/tvm/_ffi/_python. Pinning the cython version until a working fix is created. Posting this PR as an alternative to apache#15346. Change-Id: Id817aea375e1ed84c807c265ca4cc42c1757bca0
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This seems sensible given updating in Conda likely requires a bit of effort
I think it is better to see if we can get #15346 through, we could remove 3.7 requirement from the conda there |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Instead of pinning package to a lower version, we might want to fix this particular issue instead to get consistent CI vs user/developer-end behavior
We tried, we couldn't make it work, preference is not to block this PR which fixes the immediate issue.
@tqchen / @junrushao in an ideal world, we would fix everything. As you can see from #15346, it's not straightforward due to how neglected Conda is. I will merge this to resolve the issue and get things back into a stable state; if you can correct Conda and update Cython, that'd be great, we lack the expertise in this area 😸 |
Cython 3.0.0 was recently released, but it is incompatible with the current .pxi definitions in python/tvm/_ffi/_cpython. Pinning the cython version until a working fix is created.
Posting this PR as an alternative to #15346.