[Hexagon] Simplify Mul->Sub->Conv to Conv->Add when possible #15367
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When one of the inputs to Mul and Sub are constant scalars, we have the following algebraic identity:
Let res[p,q,r,s] denote the result of Mul(a, c1)->Sub(c2)->Conv(W) pattern
res[p,q,r,s] = Conv(ac1 - c2, W)
= SUM{i=[0,c-1], j=[0,kh-1], k=[0,kw-1]}
{(a[p,i,r+j,s+k] * c1 - c2) * W[q,i,j,k]}
= SUM{i=[0,c-1], j=[0,kh-1], k=[0,kw-1]}
{a[p,i,r+j,s+k] * c1 * W[q,i,j,k]} - c2 * W[q,i,j,k]}
= Conv(a, Wc1) + Conv(0-c2, W)
Since Conv(0-c2,W) and W*c1 are constant terms, they could be computed during compile time.