Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[TIR] Fix Primitive Rfactor DType #15413

Merged
merged 1 commit into from
Jul 26, 2023
Merged

Conversation

Hzfengsy
Copy link
Member

The rfactor primitive will create/rewrite two blocks, together with the block read/write regions. However, the generated read/write region extents are invalid when it's an int64 index. This commit fixes the issue.

cc @MasterJH5574

@tvm-bot
Copy link
Collaborator

tvm-bot commented Jul 26, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@github-actions github-actions bot requested a review from MasterJH5574 July 26, 2023 14:11
The rfactor primitive will create/rewrite two blocks, together with the
block read/write regions. However, the generated read/write region extents
are not valid when it's a int64 index. This commit fixes the issue.
Copy link
Contributor

@MasterJH5574 MasterJH5574 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! dtype is indeed something we didn't pay attention to when wrote these schedule primitives.

Copy link
Member

@junrushao junrushao left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fix!

@MasterJH5574 MasterJH5574 merged commit 3e00253 into apache:main Jul 26, 2023
@Hzfengsy Hzfengsy deleted the rfactor_dtype branch July 30, 2023 05:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants