Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Relay] [Bugfix] Fix some bugs of dominator pattern #15473

Merged
merged 2 commits into from
Aug 4, 2023

Conversation

kfeng123
Copy link
Contributor

@kfeng123 kfeng123 commented Aug 3, 2023

This PR solves Issue 1 and Issue 2 of dominator pattern as described in the pre-RFC

@tvm-bot
Copy link
Collaborator

tvm-bot commented Aug 3, 2023

Thanks for contributing to TVM! Please refer to the contributing guidelines https://tvm.apache.org/docs/contribute/ for useful information and tips. Please request code reviews from Reviewers by @-ing them in a comment.

Generated by tvm-bot

@kfeng123 kfeng123 changed the title Improve dominator pattern [Relay] [Bugfix] Fix some bugs of dominator pattern Aug 3, 2023
@tqchen
Copy link
Member

tqchen commented Aug 4, 2023

cc @ganler @masahi @yelite would be good if you can help review. @kfeng123 can you also send a PR to unity and update dominator pattern in https://github.com/apache/tvm/blob/unity/include/tvm/relax/dataflow_pattern.h Thank you!

@ganler
Copy link
Contributor

ganler commented Aug 4, 2023

cc @ganler @masahi @yelite would be good if you can help review. @kfeng123 can you also send a PR to unity and update dominator pattern in https://github.com/apache/tvm/blob/unity/include/tvm/relax/dataflow_pattern.h Thank you!

Note that Relax pattern language does not syntactically model topological patterns such as the dominator pattern, but instead dependency constraints need to be specified to model such patterns.

I need to take a while to follow up the pre-RFC for better understanding the intent of this PR but feel free to go ahead merging it without me. :)

@masahi masahi merged commit ac99367 into apache:main Aug 4, 2023
@kfeng123
Copy link
Contributor Author

kfeng123 commented Aug 5, 2023

I am not familiar with the unity branch. I would like to learn the pattern matching design there and contribute to it. But it may take some time.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants