Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[TOPI][ADRENO] Add conv2d transpose nchw texture schedule #15786

Merged
merged 18 commits into from
Nov 15, 2023
Merged

[TOPI][ADRENO] Add conv2d transpose nchw texture schedule #15786

merged 18 commits into from
Nov 15, 2023

Conversation

krishnaraj36
Copy link
Contributor

Added the conv2d transpose strategy for adreno target and enable the optimized schedule.

@krishnaraj36
[TOPI][ADRENO] Add conv2d transpose nchw texture schedule
59c2487 
Added the conv2d transpose strategy for adreno target and enable the
optimized schedule.
@krishnaraj36 krishnaraj36 changed the title [TOPI][ADRENO] Add conv2d transpose nchw texture schedule. [TOPI][ADRENO] Add conv2d transpose nchw texture schedule Sep 20, 2023
@krishnaraj36
Copy link
Contributor Author

@srkreddy1238 : Please review the PR

@krishnaraj36
Copy link
Contributor Author

@srkreddy1238 : Please review

@srkreddy1238
Copy link
Contributor

Over all LGTM. Few comments above.

@srkreddy1238 srkreddy1238 requested a review from echuraev October 10, 2023 17:28
echuraev
echuraev reviewed Oct 11, 2023
View reviewed changes
Copy link
Contributor

@echuraev echuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you for your PR. Some of my comments:

python/tvm/relay/op/strategy/adreno.py Show resolved Hide resolved
python/tvm/topi/adreno/conv2d_transpose_nchw.py Show resolved Hide resolved
python/tvm/topi/adreno/conv2d_transpose_nchw.py Show resolved Hide resolved
python/tvm/topi/adreno/conv2d_transpose_nchw.py Show resolved Hide resolved
python/tvm/topi/adreno/conv2d_transpose_nchw.py Show resolved Hide resolved
srkreddy1238
srkreddy1238 requested changes Nov 4, 2023
View reviewed changes
Copy link
Contributor

@srkreddy1238 srkreddy1238 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost good to go except couple of tests.

python/tvm/relay/op/strategy/adreno.py Show resolved Hide resolved
tests/python/relay/opencl_texture/test_conv2d_transpose_nchw_texture.py Outdated Show resolved Hide resolved
srkreddy1238
srkreddy1238 approved these changes Nov 8, 2023
View reviewed changes
Copy link
Contributor

@srkreddy1238 srkreddy1238 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@krishnaraj36
Copy link
Contributor Author

@echuraev : Please review and if all looks good, please approve the PR.

Thanks

echuraev
echuraev approved these changes Nov 15, 2023
View reviewed changes
Copy link
Contributor

@echuraev echuraev left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks!

@echuraev echuraev merged commit 015da7c into apache:main Nov 15, 2023
@ysh329 ysh329 mentioned this pull request Jan 11, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@echuraev echuraev echuraev approved these changes

@srkreddy1238 srkreddy1238 srkreddy1238 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@krishnaraj36 @srkreddy1238 @echuraev