-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Unity][Dlight] Enabling Fast and Efficient Kernel Generation by leveraging Hardware information #16440
Draft
LeiWang1999
wants to merge
42
commits into
apache:main
Choose a base branch
from
LeiWang1999:dev/fast_dlight
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
LeiWang1999
commented
Feb 2, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we only had shared.dyn
because the merge_shared_memory can only merge dynamic, currently we can also enable static shared memory merge.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request serves as an enhancement to Dlight. This update primarily focuses on incorporating hardware information to recommend tile candidates, which enables fast tuning.
Below is a brief summary of the major changes:
Introduce dl.ApplyFastTuning Pass
new flag for skip_simplify
schedule::reindex
: This addition can help avoid over-optimization of eliminating unit loops. This flag functions similarly topreserve_unit_loop
.improve compute_inline.cc to enhance the simplification on some complex inline case (e.g. layout transform)
simple bug fixes:
Related discussion: https://discuss.tvm.apache.org/t/dlight-enabling-fast-and-efficient-kernel-generation-by-leveraging-hardware-information/16273
TODO Items of this pull request: