[BugFix] Use x*x*x instead of pow(x,3) #16518
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR changes
topi.power(x,3)
ingelu_tanh
tox * x * x
. Subsequently, we add a warning whenpow(x, y)
, wherey >= 3
, is detected.This is motivated by, in ROCm,
pow(x, y)
returnsNaN
whenx < 0
andy >= 3
. This is shown below: