[Relax][BlockBuilder] Use PrimValue to provide tir_vars #17087
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Prior to this commit, if a TIR variable was required to compute the output of
BlockBuilder.call_te
, but that TIR variable could not be inferred from the shape of any tensor arguments, it would be provided in an optionaltir_vars
argument toR.call_tir
. In C++, this would be then be accessed as an optionalcall->args[2].as<ShapeExprNode>()
.This extra argument can cause unexpected bugs. For example, the bug that was fixed in #17086 was caused by
RewriteDataflowReshape
identifying the output buffer usingprim_func->buffer_map.Get(prim_func->params.back())
, which is only correct iftir_vars
is empty. Rather than fixing these issues as they come up, it would be better to make the general Relax guarantees stronger by removing thetir_vars
argument altogether.Use of extra
R.shape
parameter to specify additionaltir_vars
predates the existence ofrelax::PrimValue
, and is no longer required. This commit updatesBlockBuilder.call_te
to use additionalrelax.PrimValue
arguments to handle symbolic values that cannot be inferred from tensor shapes, rather thantir_vars
.