[FIX][TOPI][strided_slice] Fix topi.strided_slice output shape #17502
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
relax.strided_slice given a assume_inbound flag
…is assumed in the associated unit tests moved misplaced function description fixed shape error and added a assume_inbound=True to test_strided_slice_symbolic_sliced_axis added param description for assume_inbound
Hzfengsy
approved these changes
Nov 10, 2024
| """relax.op.strided_slice FLegalize must support dynamic begin/end""" | ||
|
|
||
| @I.ir_module | ||
| class before: |
There was a problem hiding this comment.
You can use # fmt: off and # fmt: on to disable black for specific code (e.g. TVMScript)
PatrikPerssonInceptron
deleted the
feature/topi.strided_slice-shape-fix-v2
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixed inconsistency between relax.strided_slice output shape and topi.strided_slice output shape when assume_inbound
is set to false.
I added an assume_inbound flag to topi.strided_slice. If it is false then the begin and end indices are canonicalized before the dimension length is calculated. To avoid introducing duplicate code i removed the corresponding functions from relax/../index.cc and instead reference the new functions defined in include/tvm/topi/transform.h.
I added a regression test for the case with assume_inbound = false when the end of the slice is at infinity, e.g. v[begin:], which previously caused an incorrect output shape.