Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[LLVM] Make compilable with LLVM-20 #17547

Merged
merged 6 commits into from
Dec 2, 2024
Merged

[LLVM] Make compilable with LLVM-20 #17547

merged 6 commits into from
Dec 2, 2024

Conversation

parsifal-47
Copy link
Contributor

Hello All,
this PR adapts for LLVM-20 changes. Please feel free to let me know if there is a better way to do it.
Thank you!

@parsifal-47 parsifal-47 mentioned this pull request Nov 29, 2024
Closed
@cbalint13 cbalint13 self-assigned this Nov 29, 2024
@cbalint13
Copy link
Contributor

Thank you @parsifal-47 !

This fix is welcome, it looks good to me.

cbalint13
cbalint13 approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@cbalint13 cbalint13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

cbalint13
cbalint13 requested changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@cbalint13 cbalint13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apologies for previous rushed approval, I tested the proposal on my local and found these.

src/target/llvm/codegen_cpu.cc Outdated Show resolved Hide resolved
src/target/llvm/codegen_cpu.cc Outdated Show resolved Hide resolved
src/target/llvm/codegen_llvm.cc Outdated Show resolved Hide resolved
@parsifal-47
Copy link
Contributor Author

absolutely no problem @cbalint13 , let me fix the follow-ups and get back to you!

@parsifal-47
Copy link
Contributor Author

Apologies for previous rushed approval, I tested the proposal on my local and found these.

no problem, I have resolved all deprecation warnings, but I am not very confident about llvmGetPointerTo macro, let me know what you think, thank you!

cbalint13
cbalint13 approved these changes Nov 29, 2024
View reviewed changes
Copy link
Contributor

@cbalint13 cbalint13 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this really handles all the warnings for deprecation.

@cbalint13
Copy link
Contributor

@parsifal-47 , thank you for the work !
Let's further make sure all the CI tasks are in green to be able to merge it.

@cbalint13 cbalint13 changed the title Make compilable with LLVM-20 [LLVM] Make compilable with LLVM-20 Nov 30, 2024
@cbalint13 cbalint13 merged commit 513c2be into apache:main Dec 2, 2024
18 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cbalint13 cbalint13 cbalint13 approved these changes

Assignees

@cbalint13 cbalint13

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@parsifal-47 @cbalint13