Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[CI][Contrib] Add ACL docker installation #5916

Merged
merged 1 commit into from
Jul 10, 2020

Conversation

lhutton1
Copy link
Contributor

This patch adds a cross-compiled ACL build to the ci_cpu dockerfile used for CI.

Change-Id: I66e1521ab553306bc7367b65acc0363e750f0211

@comaniac
Copy link
Contributor

I'd suggest including ubuntu_install_acl.sh in this PR instead of in #5915, and let this PR in first to make sure #5915 could pass the CI.

@junrushao
Copy link
Member

Just a dumb question. Do we need an ARM device to run ACL?

@lhutton1
Copy link
Contributor Author

@junrushao1994 Yes ACL can only be used on Arm hardware. We've included this cross-build in the docker container to make it easier for anyone wanting to use ACL with RPC. They just copy across the libraries they need to the remote device rather than needing to worry about building a new container.

Copy link
Member

@tqchen tqchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

NOTE, shall we rename acl to armcl or armcompute? because ACL can mean different things for people who are working on NLP

This patch adds a cross-compiled ACL build to the ci_cpu dockerfile used for CI.

Change-Id: I66e1521ab553306bc7367b65acc0363e750f0211
@tqchen tqchen merged commit e329069 into apache:master Jul 10, 2020
@tqchen
Copy link
Member

tqchen commented Jul 10, 2020

Thanks @lhutton1 !

trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Jul 14, 2020
…5916)

This patch adds a cross-compiled ACL build to the ci_cpu dockerfile used for CI.

Change-Id: I66e1521ab553306bc7367b65acc0363e750f0211
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jul 14, 2020
…5916)

This patch adds a cross-compiled ACL build to the ci_cpu dockerfile used for CI.

Change-Id: I66e1521ab553306bc7367b65acc0363e750f0211
@lhutton1 lhutton1 deleted the acl-docker-installation branch July 24, 2020 10:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants