-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Relay] support i64 indices #6143
Conversation
@yzhliu @tqchen It's ready for review. I'm not sure if this pr introduces perf. regression (because some models may contain i64 indexing, and not all i64 can be narrowed). Do we need a compilation flag like
|
Let us confirm the major networks and also notify the parties. We could have an option |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, excited for i64 support to finally make it in!
@hzfan FYI, I found that Keras MobileNetV2 model experiences a heavy perf regression with i64 indices enabled. This is on an AWS m5.12xlarge instance. |
Remove i32 casting at https://github.com/apache/incubator-tvm/blob/master/src/relay/backend/compile_engine.cc#L83