Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FFI][BUGFIX] Fix memory leak when Pac callback argument is NDArray #6744

Merged
merged 3 commits into from
Oct 24, 2020
Merged

[FFI][BUGFIX] Fix memory leak when Pac callback argument is NDArray #6744

merged 3 commits into from
Oct 24, 2020

Conversation

tqchen
Copy link
Member

@tqchen tqchen commented Oct 23, 2020

Co-authored-by: Matthew Brookhart mbrookhart@octoml.ai

@tqchen
[FFI][BUGFIX] Fix leak when Packed callback arg is ndarray.
2a003fd 
Co-authored-by: Matthew Brookhart <mbrookhart@octoml.ai>
@tqchen
Copy link
Member Author

tqchen commented Oct 23, 2020 •
edited
Loading

kudos to @mbrookhart who uncovered this bug initially

@tqchen
Copy link
Member Author

tqchen commented Oct 23, 2020

cc @jroesch @mbrookhart @junrushao1994 @yzhliu

mbrookhart
mbrookhart approved these changes Oct 23, 2020
View reviewed changes
Copy link
Contributor

@mbrookhart mbrookhart left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the fast turn arround! This fixes several subtle bugs I've been dealing with lately.

@tqchen
Copy link
Member Author

tqchen commented Oct 23, 2020

Also pushed fix for jvm and rust, would be great if @jroesch @yzhliu can followup PR with test cases that reflects the python one. I will work a bit to revamp the typescript test later

@tqchen @junrushao
Update rust/tvm-rt/src/to_function.rs
55c6e9d 
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
@tqchen tqchen merged commit fc69f68 into apache:main Oct 24, 2020
@tqchen tqchen mentioned this pull request Oct 24, 2020
Merged
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Oct 29, 2020
@tqchen @junrushao
[FFI][BUGFIX] Fix memory leak when Pac callback argument is NDArray (a…
d485222 
…pache#6744)

* [FFI][BUGFIX] Fix leak when Packed callback arg is ndarray.

Co-authored-by: Matthew Brookhart <mbrookhart@octoml.ai>

* Fix for rust ts and jvm

* Update rust/tvm-rt/src/to_function.rs

Co-authored-by: Junru Shao <junrushao1994@gmail.com>

Co-authored-by: Matthew Brookhart <mbrookhart@octoml.ai>
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
tqchen added a commit to tqchen/tvm that referenced this pull request Nov 2, 2020
@tqchen @junrushao
[FFI][BUGFIX] Fix memory leak when Pac callback argument is NDArray (a…
6191fe2 
…pache#6744)

* [FFI][BUGFIX] Fix leak when Packed callback arg is ndarray.

Co-authored-by: Matthew Brookhart <mbrookhart@octoml.ai>

* Fix for rust ts and jvm

* Update rust/tvm-rt/src/to_function.rs

Co-authored-by: Junru Shao <junrushao1994@gmail.com>

Co-authored-by: Matthew Brookhart <mbrookhart@octoml.ai>
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
tqchen added a commit that referenced this pull request Nov 2, 2020
@tqchen @junrushao
[FFI][BUGFIX] Fix memory leak when Pac callback argument is NDArray (#…
091a427 
…6744) (#6821)


Co-authored-by: Matthew Brookhart <mbrookhart@octoml.ai>
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 2, 2020
@tqchen @junrushao
[FFI][BUGFIX] Fix memory leak when Pac callback argument is NDArray (a…
1aae699 
…pache#6744)

* [FFI][BUGFIX] Fix leak when Packed callback arg is ndarray.

Co-authored-by: Matthew Brookhart <mbrookhart@octoml.ai>

* Fix for rust ts and jvm

* Update rust/tvm-rt/src/to_function.rs

Co-authored-by: Junru Shao <junrushao1994@gmail.com>

Co-authored-by: Matthew Brookhart <mbrookhart@octoml.ai>
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
trevor-m pushed a commit to trevor-m/tvm that referenced this pull request Dec 4, 2020
@tqchen @junrushao
[FFI][BUGFIX] Fix memory leak when Pac callback argument is NDArray (a…
a2816b8 
…pache#6744)

* [FFI][BUGFIX] Fix leak when Packed callback arg is ndarray.

Co-authored-by: Matthew Brookhart <mbrookhart@octoml.ai>

* Fix for rust ts and jvm

* Update rust/tvm-rt/src/to_function.rs

Co-authored-by: Junru Shao <junrushao1994@gmail.com>

Co-authored-by: Matthew Brookhart <mbrookhart@octoml.ai>
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Dec 4, 2020
@tqchen @junrushao @trevor-m
[FFI][BUGFIX] Fix memory leak when Pac callback argument is NDArray (a…
76b5c9f 
…pache#6744)

* [FFI][BUGFIX] Fix leak when Packed callback arg is ndarray.

Co-authored-by: Matthew Brookhart <mbrookhart@octoml.ai>

* Fix for rust ts and jvm

* Update rust/tvm-rt/src/to_function.rs

Co-authored-by: Junru Shao <junrushao1994@gmail.com>

Co-authored-by: Matthew Brookhart <mbrookhart@octoml.ai>
Co-authored-by: Junru Shao <junrushao1994@gmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@junrushao junrushao junrushao approved these changes

@mbrookhart mbrookhart mbrookhart approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tqchen @mbrookhart @junrushao