[Diagnostics] Add environment variable for controlling top-level printing and fix issue with pretty printing/parsing roundtrip. #6874
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jroesch
changed the title
tkonolige
reviewed
Nov 11, 2020
python/tvm/__init__.py
Outdated
| tvm_backtrace = bool(int(tvm_backtrace)) | ||
| except ValueError: | ||
| raise ValueError( | ||
| "invalid value for TVM_BACKTRACE `{tvm_backtrace}`, please set to 0 or 1.") |
There was a problem hiding this comment.
Suggested change
| "invalid value for TVM_BACKTRACE `{tvm_backtrace}`, please set to 0 or 1.") | |
| f"invalid value for TVM_BACKTRACE `{tvm_backtrace}`, please set to 0 or 1.") |
jroesch
changed the title
mbrookhart
approved these changes
Dec 3, 2020
There was a problem hiding this comment.
Thanks, Jared, this fixes a number of issues I've seen in complicated models.
@tkonolige Do you want to take another look?
|
Thanks @jroesch @tkonolige ! |
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 3, 2020
…ting and fix issue with pretty printing/parsing roundtrip. (apache#6874) * Update Parser in order to handle the NMS code * Add support for displaying traces optionally * WIP * Fix * Fix error reporting in parser and clean up __init__.py due to CR * Format * Quick fix for If * Fix format * Fix lint
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
…ting and fix issue with pretty printing/parsing roundtrip. (apache#6874) * Update Parser in order to handle the NMS code * Add support for displaying traces optionally * WIP * Fix * Fix error reporting in parser and clean up __init__.py due to CR * Format * Quick fix for If * Fix format * Fix lint
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
…ting and fix issue with pretty printing/parsing roundtrip. (apache#6874) * Update Parser in order to handle the NMS code * Add support for displaying traces optionally * WIP * Fix * Fix error reporting in parser and clean up __init__.py due to CR * Format * Quick fix for If * Fix format * Fix lint
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
…ting and fix issue with pretty printing/parsing roundtrip. (apache#6874) * Update Parser in order to handle the NMS code * Add support for displaying traces optionally * WIP * Fix * Fix error reporting in parser and clean up __init__.py due to CR * Format * Quick fix for If * Fix format * Fix lint
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix some parsing issues from NMS and add top-level environment variables. cc @electriclilies @mbrookhart @jwfromm @tkonolige