[Relay] Add DefuseOps pass #6946
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
merrymercy
force-pushed
the
pr-defuse-ops
branch
from
8305074
to
7637f29
Compare
merrymercy
force-pushed
the
pr-defuse-ops
branch
from
7637f29
to
7f34456
Compare
merrymercy
requested review from
comaniac,
FrozenGene,
jroesch and
tqchen
and removed request for
jroesch
FrozenGene
reviewed
Nov 22, 2020
|
cc @zhiics @mbrookhart it would be great if you can also take a look at it |
merrymercy
force-pushed
the
pr-defuse-ops
branch
3 times, most recently
from
97dde7e
to
7c34768
Compare
Co-authored-by: minminsun <minmin.smm@alibaba-inc.com>
merrymercy
force-pushed
the
pr-defuse-ops
branch
from
7c34768
to
1d6dee1
Compare
|
@FrozenGene comments are addressed |
FrozenGene
approved these changes
Nov 23, 2020
jcf94
approved these changes
Nov 23, 2020
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 2, 2020
Co-authored-by: minminsun <minmin.smm@alibaba-inc.com> Co-authored-by: minminsun <minmin.smm@alibaba-inc.com>
trevor-m
pushed a commit
to trevor-m/tvm
that referenced
this pull request
Dec 4, 2020
Co-authored-by: minminsun <minmin.smm@alibaba-inc.com> Co-authored-by: minminsun <minmin.smm@alibaba-inc.com>
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Dec 4, 2020
Co-authored-by: minminsun <minmin.smm@alibaba-inc.com> Co-authored-by: minminsun <minmin.smm@alibaba-inc.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a DefuseOps pass. DefuseOps is an inverse operation of FuseOps pass. It transforms a fused program returned by
relay::transform::FuseOpsinto the program before FuseOps (i.e.,x == DefuseOps(FuseOps(x))).This pass is necessary for a layout rewrite pass in Ansor auto-scheduler. Because FoldConstant cannot work across the boundary of the fused Primitive function. When we want to use FoldConstant after fusion, we have to defuse it, apply FoldConstant and fuse it again.
co-authored by @minminsun