-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Sparse fill empty rows op #7126
Conversation
@tkonolige @mbrookhart PTAL and approve or request changes explicitly. Thanks. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I've suggested some more small changes.
Given the discussion with @mbrookhart, I think you should use dynamic shape here.
@comaniac Every time I select request changes on GitHub, it switches it "suggested changes". Maybe because I am not a committer? |
Yes that's the case, but we'll do our best to make sure all comments are addressed before merging. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't fully understand the point of these sparse op PRs, is there a particular model we're trying to target? It's hard for me to review without understanding the use case.
There are issues in this set of PRs that will prevent them from working on dynamically shaped input tensors. I don't think that's a blocker, but it could cause headaches down the road.
Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>
Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>
Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>
Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>
Co-authored-by: Tristan Konolige <tristan.konolige@gmail.com>
@tkonolige @mbrookhart This PR is ready for re-review as well whenever you are back from vacation. |
This PR is to support SparseFillEmptyRows Op (similar to https://www.tensorflow.org/api_docs/python/tf/sparse/fill_empty_rows) in relay. Frontend code for the TF Op will be added in a following PR since it combines multiple ops together)