[TOPI] Treat undefined elements as constants in Array #7232
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
comaniac
changed the title
|
I didn't know we could use None. Is there a way to test it in the unit tests? I'd like to see a unit test, but otherwise it looks good. |
It is supported here: https://github.com/apache/tvm/blob/main/include/tvm/topi/transform.h#L658 (so does |
mbrookhart
approved these changes
Jan 8, 2021
yzhliu
approved these changes
Jan 9, 2021
|
Thanks @mbrookhart @yzhliu |
tkonolige
pushed a commit
to tkonolige/incubator-tvm
that referenced
this pull request
Jan 11, 2021
* [TOPI] Treat undefined elements as constants in Array * Add a checker * fix * add test case
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jan 14, 2021
* [TOPI] Treat undefined elements as constants in Array * Add a checker * fix * add test case
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jan 18, 2021
* [TOPI] Treat undefined elements as constants in Array * Add a checker * fix * add test case
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Jan 20, 2021
* [TOPI] Treat undefined elements as constants in Array * Add a checker * fix * add test case
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jan 21, 2021
* [TOPI] Treat undefined elements as constants in Array * Add a checker * fix * add test case
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
* [TOPI] Treat undefined elements as constants in Array * Add a checker * fix * add test case
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#7018 introduces the dynamic support to
strided_slice. However, in the following case, the static workload will be treat as a dynamic:This is because the
Noneinendis notIntImmNodeand will be judged as a non-constant array. This PR changes the behavior by ignoring the undefined elements.In addition, the dynamic path also assumes
stridesarray is always given, but it will be initialized to array of 1 after this path. Since I'm not sure what's the right behavior, I only add a checker to error out.cc @kevinthesun @mbrookhart