-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[µTVM] Add ST STM32F746 disco board to tflite tutorial script #7254
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks like this failed due to an unrelated CI problem. can you submit something to the PR branch to retrigger the CI? I think you could either commit --amend and force-push or add an empty commit
Currently tutorial script 'micro_tflite.py' assumes that all boards with target STM32F746 are Nucleo boards. As a consequence once that target is selected the script automatically defaults to the Nucleo board. However, the STM32F746 is also used on Discovery Kit boards (aka disco) which are quite similar but have some differences, so Nucleo config and final image don't work on the disco boards. That commit adds a way to select a different dev board and adds comments accordingly, informing how to use the script with STM32F746 disco boards. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
@areusch hrm same error again? oh nm, it's still building : ) |
@areusch you're right, it was just a matter of re-triggering the build. Tests seem ok now :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@tmoreau89 want to merge?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @gromero LGTM
this will get updated on docs.tvm.ai when we regenerate the site, will probably happen later on today or tomorrow. |
…#7254) Currently tutorial script 'micro_tflite.py' assumes that all boards with target STM32F746 are Nucleo boards. As a consequence once that target is selected the script automatically defaults to the Nucleo board. However, the STM32F746 is also used on Discovery Kit boards (aka disco) which are quite similar but have some differences, so Nucleo config and final image don't work on the disco boards. That commit adds a way to select a different dev board and adds comments accordingly, informing how to use the script with STM32F746 disco boards. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
…#7254) Currently tutorial script 'micro_tflite.py' assumes that all boards with target STM32F746 are Nucleo boards. As a consequence once that target is selected the script automatically defaults to the Nucleo board. However, the STM32F746 is also used on Discovery Kit boards (aka disco) which are quite similar but have some differences, so Nucleo config and final image don't work on the disco boards. That commit adds a way to select a different dev board and adds comments accordingly, informing how to use the script with STM32F746 disco boards. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
…#7254) Currently tutorial script 'micro_tflite.py' assumes that all boards with target STM32F746 are Nucleo boards. As a consequence once that target is selected the script automatically defaults to the Nucleo board. However, the STM32F746 is also used on Discovery Kit boards (aka disco) which are quite similar but have some differences, so Nucleo config and final image don't work on the disco boards. That commit adds a way to select a different dev board and adds comments accordingly, informing how to use the script with STM32F746 disco boards. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
…#7254) Currently tutorial script 'micro_tflite.py' assumes that all boards with target STM32F746 are Nucleo boards. As a consequence once that target is selected the script automatically defaults to the Nucleo board. However, the STM32F746 is also used on Discovery Kit boards (aka disco) which are quite similar but have some differences, so Nucleo config and final image don't work on the disco boards. That commit adds a way to select a different dev board and adds comments accordingly, informing how to use the script with STM32F746 disco boards. Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Currently tutorial script 'micro_tflite.py' assumes all boards with target
STM32F746 are the same. As a consequence once that target is selected the
script automatically defaults to the Nucleo board. However, the STM32F746
is also used on Discovery Kit boards (aka disco) which are quite similar
but have some differences, so Nucleo config and final image don't work on
the disco boards.
That commit adds a way to select a different dev board and adds comments
accordingly, informing how to use the script with the disco boards.
Signed-off-by: Gustavo Romero gustavo.romero@linaro.org
Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.