Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[µTVM] Add ST STM32F746 disco board to tflite tutorial script #7254

Merged
merged 1 commit into from
Jan 15, 2021

Conversation

gromero
Copy link
Contributor

@gromero gromero commented Jan 11, 2021

Currently tutorial script 'micro_tflite.py' assumes all boards with target
STM32F746 are the same. As a consequence once that target is selected the
script automatically defaults to the Nucleo board. However, the STM32F746
is also used on Discovery Kit boards (aka disco) which are quite similar
but have some differences, so Nucleo config and final image don't work on
the disco boards.

That commit adds a way to select a different dev board and adds comments
accordingly, informing how to use the script with the disco boards.

Signed-off-by: Gustavo Romero gustavo.romero@linaro.org

Thanks for contributing to TVM! Please refer to guideline https://tvm.apache.org/docs/contribute/ for useful information and tips. After the pull request is submitted, please request code reviews from Reviewers by @ them in the pull request thread.

@gromero
Copy link
Contributor Author

gromero commented Jan 11, 2021

@areusch Would you mind to review it? It's about our discussion last week about adding disco boards to the tflite tutorial as well. It depends on #7225

Copy link
Contributor

@areusch areusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks like this failed due to an unrelated CI problem. can you submit something to the PR branch to retrigger the CI? I think you could either commit --amend and force-push or add an empty commit

Currently tutorial script 'micro_tflite.py' assumes that all boards with
target STM32F746 are Nucleo boards. As a consequence once that target is
selected the script automatically defaults to the Nucleo board. However,
the STM32F746 is also used on Discovery Kit boards (aka disco) which are
quite similar but have some differences, so Nucleo config and final image
don't work on the disco boards.

That commit adds a way to select a different dev board and adds comments
accordingly, informing how to use the script with STM32F746 disco boards.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
@gromero
Copy link
Contributor Author

gromero commented Jan 14, 2021

@areusch hrm same error again?

oh nm, it's still building : )

@gromero
Copy link
Contributor Author

gromero commented Jan 15, 2021

@areusch you're right, it was just a matter of re-triggering the build. Tests seem ok now :)

Copy link
Contributor

@areusch areusch left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@tmoreau89 want to merge?

Copy link
Contributor

@tmoreau89 tmoreau89 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @gromero LGTM

@tmoreau89 tmoreau89 merged commit c3f50ff into apache:main Jan 15, 2021
@areusch
Copy link
Contributor

areusch commented Jan 15, 2021

this will get updated on docs.tvm.ai when we regenerate the site, will probably happen later on today or tomorrow.

masahi pushed a commit to masahi/tvm that referenced this pull request Jan 18, 2021
…#7254)

Currently tutorial script 'micro_tflite.py' assumes that all boards with
target STM32F746 are Nucleo boards. As a consequence once that target is
selected the script automatically defaults to the Nucleo board. However,
the STM32F746 is also used on Discovery Kit boards (aka disco) which are
quite similar but have some differences, so Nucleo config and final image
don't work on the disco boards.

That commit adds a way to select a different dev board and adds comments
accordingly, informing how to use the script with STM32F746 disco boards.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
TusharKanekiDey pushed a commit to TusharKanekiDey/tvm that referenced this pull request Jan 20, 2021
…#7254)

Currently tutorial script 'micro_tflite.py' assumes that all boards with
target STM32F746 are Nucleo boards. As a consequence once that target is
selected the script automatically defaults to the Nucleo board. However,
the STM32F746 is also used on Discovery Kit boards (aka disco) which are
quite similar but have some differences, so Nucleo config and final image
don't work on the disco boards.

That commit adds a way to select a different dev board and adds comments
accordingly, informing how to use the script with STM32F746 disco boards.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
trevor-m pushed a commit to neo-ai/tvm that referenced this pull request Jan 21, 2021
…#7254)

Currently tutorial script 'micro_tflite.py' assumes that all boards with
target STM32F746 are Nucleo boards. As a consequence once that target is
selected the script automatically defaults to the Nucleo board. However,
the STM32F746 is also used on Discovery Kit boards (aka disco) which are
quite similar but have some differences, so Nucleo config and final image
don't work on the disco boards.

That commit adds a way to select a different dev board and adds comments
accordingly, informing how to use the script with STM32F746 disco boards.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
electriclilies pushed a commit to electriclilies/tvm that referenced this pull request Feb 18, 2021
…#7254)

Currently tutorial script 'micro_tflite.py' assumes that all boards with
target STM32F746 are Nucleo boards. As a consequence once that target is
selected the script automatically defaults to the Nucleo board. However,
the STM32F746 is also used on Discovery Kit boards (aka disco) which are
quite similar but have some differences, so Nucleo config and final image
don't work on the disco boards.

That commit adds a way to select a different dev board and adds comments
accordingly, informing how to use the script with STM32F746 disco boards.

Signed-off-by: Gustavo Romero <gustavo.romero@linaro.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants