[PatternLang][Bugfix] Ensure CallNode attrs are not undefined before checking #7278
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…rs may be undefined)
mbrookhart
approved these changes
Jan 14, 2021
|
I'm experimenting with some BYOC patterns that rely on matching custom annotations on call nodes -- I got a segfault when I passed it an ordinary function call |
|
Yep, this needed a null check. Sorry for the segfault, thank you for fixing it! |
|
Thanks @slyubomirsky! |
masahi
pushed a commit
to masahi/tvm
that referenced
this pull request
Jan 18, 2021
…checking (apache#7278) * Correct handling of call node attrs to handle non-operator calls (attrs may be undefined) * Linting fix
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Jan 20, 2021
…checking (apache#7278) * Correct handling of call node attrs to handle non-operator calls (attrs may be undefined) * Linting fix
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jan 21, 2021
…checking (apache#7278) * Correct handling of call node attrs to handle non-operator calls (attrs may be undefined) * Linting fix
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
…checking (apache#7278) * Correct handling of call node attrs to handle non-operator calls (attrs may be undefined) * Linting fix
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Currently, using a dataflow pattern to attempt to match attributes on a call node (for calls to ordinary Relay functions, not operators) results in a segmentation fault due to attempting to access an
AttrsNodethat is not present. This PR checks if the attributes node exists first to prevent the segfault and adds unit tests for this case.Please review @jroesch @mbrookhart