[FIX,AUTOTVM] Add flop counts to cublas #7297
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also print which op was missing flops.
comaniac
requested changes
Jan 16, 2021
| @@ -44,6 +44,8 @@ def dense_cublas(cfg, data, weight, bias=None, out_dtype=None): | |||
| matmul = cublas.matmul(data, weight, False, True) | |||
| if isinstance(batch, int): | |||
| cfg.add_flop(batch * in_dim * out_dim * 2) | |||
| else: | |||
| cfg.add_flop(batch.value * in_dim * out_dim * 2) | |||
There was a problem hiding this comment.
Should have an assertion to make sure batch is a TVM container type.
There was a problem hiding this comment.
I've added a check that it is int or IntImm, would any other types show up here?
There was a problem hiding this comment.
I don't think so. Let's use the current version to make sure we could catch any exception.
There was a problem hiding this comment.
Ah it turns out that you may get Var in the case of dynamic shape. For other TOPI templates, many of them just ignore the flops when the shape is dynamic. You could do the same.
Co-authored-by: Cody Yu <comaniac0422@gmail.com>
tkonolige
force-pushed
the
fix_autotvm_tune_cublas
branch
from
3d98306
to
6fc1fa0
Compare
comaniac
approved these changes
Jan 16, 2021
| @@ -44,6 +44,8 @@ def dense_cublas(cfg, data, weight, bias=None, out_dtype=None): | |||
| matmul = cublas.matmul(data, weight, False, True) | |||
| if isinstance(batch, int): | |||
| cfg.add_flop(batch * in_dim * out_dim * 2) | |||
| else: | |||
| cfg.add_flop(batch.value * in_dim * out_dim * 2) | |||
There was a problem hiding this comment.
I don't think so. Let's use the current version to make sure we could catch any exception.
|
Thanks @tkonolige |
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 11, 2021
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes a bug when trying to autotune with cublas enabled. I've also added the op name to the error messages.
@comaniac @merrymercy