[TIR][REFACTOR] ForNode introduce thread binding and remove legacy field #7306
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Remove deprecated device_api. - Add ThreadBinding for_type. - Add additional annotations.
tqchen
force-pushed
the
for-refactor
branch
2 times, most recently
from
85db354
to
307386f
Compare
to be consistent with rest of the codebase. - ForType => ForKind - Add constant prefix k to enum consts per Google C style - Introduce ForKind to the python side.
Hzfengsy
reviewed
Jan 19, 2021
jcf94
reviewed
Jan 19, 2021
junrushao
reviewed
Jan 19, 2021
junrushao
reviewed
Jan 19, 2021
jcf94
approved these changes
Jan 19, 2021
spectrometerHBH
approved these changes
Jan 19, 2021
junrushao
approved these changes
Jan 19, 2021
|
Thanks @tqchen @jcf94 @spectrometerHBH! It is merged :-) |
TusharKanekiDey
pushed a commit
to TusharKanekiDey/tvm
that referenced
this pull request
Jan 20, 2021
…eld (apache#7306) [TIR][REFACTOR] ForNode update - Remove deprecated device_api. - Add ThreadBinding for_type. - Add additional annotations. More style consistency refactor to make the ForNode to be consistent with rest of the codebase. - ForType => ForKind - Add constant prefix k to enum consts per Google C style - Introduce ForKind to the python side.
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Jan 21, 2021
…eld (apache#7306) [TIR][REFACTOR] ForNode update - Remove deprecated device_api. - Add ThreadBinding for_type. - Add additional annotations. More style consistency refactor to make the ForNode to be consistent with rest of the codebase. - ForType => ForKind - Add constant prefix k to enum consts per Google C style - Introduce ForKind to the python side.
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
…eld (apache#7306) [TIR][REFACTOR] ForNode update - Remove deprecated device_api. - Add ThreadBinding for_type. - Add additional annotations. More style consistency refactor to make the ForNode to be consistent with rest of the codebase. - ForType => ForKind - Add constant prefix k to enum consts per Google C style - Introduce ForKind to the python side.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ForNode update
More style consistency refactor to make the ForNode
to be consistent with rest of the codebase.
Note that this is mainly a IR data structure update, and compiler/script support for thread binding need to come later