-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[AutoSchedule] Sparse dense tuning support with custom sketch rule #7313
Merged
Merged
Changes from 4 commits
Commits
Show all changes
36 commits
Select commit
Hold shift + click to select a range
459f773
Add sparse dense tuning tutorial
jcf94 b577edd
Add sparse input fusion
jcf94 594fdb4
Update the dag to support output fusion
jcf94 a4b025b
Update
jcf94 a6223e0
Add task input to search_task
jcf94 f068e79
Update
jcf94 1f1a7b5
Add search_inputs to measure
jcf94 e83dfe4
Lint fix
jcf94 7ca2bd4
Lint fix
jcf94 486567a
Update
jcf94 aa7abd2
Update
jcf94 48a4e61
Update
jcf94 5b2e25a
Update
jcf94 cc111b9
Add file save load support
jcf94 9c9d974
Update
jcf94 c1a65ae
Merge branch 'main' into ansor_sparse
jcf94 2eac0c7
Update
jcf94 418f42c
Update
jcf94 1d735c8
Remove add_task_inputs API
jcf94 2083254
Update
jcf94 1622de0
Update
jcf94 b6f02cc
Update
jcf94 ca92d64
Lint fix
jcf94 2273998
Lint fix
jcf94 034dcab
Lint fix
jcf94 35ce552
Lint fix
jcf94 925fd70
Update
jcf94 56c01d9
Add example ci_log
jcf94 b5a1832
Update
jcf94 84b277d
retrigger ci
jcf94 3bd6b6f
Update
jcf94 de4170e
Update
jcf94 7e45641
Update
jcf94 7b47a06
Lint fix
jcf94 eeb9b3c
Lint fix
jcf94 cf4cb42
Lint fix
jcf94 File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We could run into the case that two matrices have the same
sparse_prefix
, but different non-zero structure. Will this cause issues? What if one of the matrices has one nonzero per row and the other has one dense row (while maintaining the same sparsity)?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Though in my test a schedule seems to have similar performance with different random sparse data, I think that may still be a potential problem. Unfortunately, I have not figured out any better solution.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You could hash the
indptr
andindices
arrays as these determine the structure. Alternatively you could hash the number of nonzeros per row.It would be interesting to study if tuning performs the same independent of structure (but for the same sparsity).