[Relay][Frontend][Onnx] Robustify Loop Importer #7353
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
masahi
approved these changes
Jan 28, 2021
|
thanks @jwfromm @mbrookhart |
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 11, 2021
* Add test for array loop. * Fixed scalar issue. * Formatting. * Fix injective schedule for dynamic shapes.
electriclilies
pushed a commit
to electriclilies/tvm
that referenced
this pull request
Feb 18, 2021
* Add test for array loop. * Fixed scalar issue. * Formatting. * Fix injective schedule for dynamic shapes.
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
* Add test for array loop. * Fixed scalar issue. * Formatting. * Fix injective schedule for dynamic shapes.
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
* Add test for array loop. * Fixed scalar issue. * Formatting. * Fix injective schedule for dynamic shapes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Although the loop importer in onnx works for simple cases, it had some issues for loops that output and accumulate tensors. This PR adds handling for both scalar and tensor outputs and corresponding tests.
Note that one issue encountered was that an injective schedule was applied to concatenate during compilation. Unfortunately, the concat in our loop has dynamic shapes which caused an invalid access in the schedule. This PR also includes a check to make sure that the shapes of concat's inputs are static before trying to vectorize.