-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Jenkinsfile changes for #7333. #7388
Conversation
Jenkinsfile
Outdated
@@ -248,6 +248,8 @@ stage('Unit Test') { | |||
unpack_lib('gpu', tvm_multilib) | |||
timeout(time: max_time, unit: 'MINUTES') { | |||
sh "${docker_run} ${ci_gpu} ./tests/scripts/task_ci_python_setup.sh" | |||
sh "${docker_run} ${ci_gpu} ./tests/scripts/task_config_build_gpu.sh" | |||
sh "${docker_run} ${ci_gpu} ./tests/scripts/task_build.sh build standalone_crt" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would this trigger rebuild of libtvm? or simply just standalone_crt
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok resolved per our discussion. we will not explicitly introduce a separate build step here; instead we will add this build to tests/scripts/task_ci_setup.sh
, which was previously tests/scripts/task_ci_python_setup.sh
f1a03cc
to
7ae7214
Compare
…ORT_PACKED_FUNC macros in packed_func.h. This is a patch PR for apache#7388. (apache#7343) Co-authored-by: JC Li <jinli@nvidia.com>
* Make build/standalone_crt available to CI unit tests. * We could do this with stash but it's complex because we would need to use wildcards. Instead, rebuild standalone_crt source tree before testing.
7ae7214
to
eb6dc25
Compare
@tqchen good to merge now? |
@areusch please resolve merge conflict |
@tqchen done |
…ORT_PACKED_FUNC macros in packed_func.h. This is a patch PR for apache#7388. (apache#7343) Co-authored-by: JC Li <jinli@nvidia.com>
…ORT_PACKED_FUNC macros in packed_func.h. This is a patch PR for apache#7388. (apache#7343) Co-authored-by: JC Li <jinli@nvidia.com>
…ORT_PACKED_FUNC macros in packed_func.h. This is a patch PR for apache#7388. (apache#7343) Co-authored-by: JC Li <jinli@nvidia.com>
…ORT_PACKED_FUNC macros in packed_func.h. This is a patch PR for apache#7388. (apache#7343) Co-authored-by: JC Li <jinli@nvidia.com>
to use wildcards. Instead, rebuild standalone_crt source tree before testing.