[RPC] Replace timestamp with counter #7389
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
FrozenGene
reviewed
Feb 2, 2021
FrozenGene
reviewed
Feb 2, 2021
comaniac
commented
Feb 2, 2021
FrozenGene
approved these changes
Feb 3, 2021
|
cc @tqchen to take a final look and merge. |
tqchen
approved these changes
Feb 5, 2021
alexwong
pushed a commit
to alexwong/tvm
that referenced
this pull request
Feb 11, 2021
Lokiiiiii
pushed a commit
to Lokiiiiii/tvm
that referenced
this pull request
Mar 2, 2021
trevor-m
pushed a commit
to neo-ai/tvm
that referenced
this pull request
Mar 2, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When tuning workload using AutoTVM, we may encounter an exception saying
< not supported between instances of function and function. The reason is we currently put RPC requests in the format of(-priority, time.time(), callback). When two requests with the samepriorityandtime.time(), then heap pop throws the error of trying to compare two callbacks. Although it seems rare to have the same timestamp for two requests, one of my colleagues encounters an exception repeatedly when tuning a task using AutoTVM on V100 GPU. As a result, I try to use a counter to replace the timestamp so that we guarantee there's no duplication. Not sure if we need thread locking here to make sure thread safe, tho.cc @tqchen @FrozenGene