-
Notifications
You must be signed in to change notification settings - Fork 3.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[Frontend][Tensorflow] Support explicit_paddings for TF 2.x #7445
Conversation
trevor-m
commented
Feb 11, 2021
•
edited
Loading
edited
- Ignore "_cloned" attr for squeeze.
- Support explicit padding for conv2d, depthwise conv2d, conv2d transpose and max_pool2d.
- Support explicit padding for conv3d also, but TF API doesnt allow you to create a conv3d op with explicit padding so there is no unit test.
I worry about we can not ignore it simply. According to doc: https://www.tensorflow.org/api_docs/python/tf/nn/conv2d
If |
Thanks for the review! That is true, I will update this PR to properly support explicit padding. |
Thanks @trevor-m Our convolution op ignore |
@FrozenGene I've updated the PR with explicit padding support. PTAL I noticed that while many ops now have the "explicit_paddings" attribute, the ability to actually use explicit padding in the TF python API has only exposed it for a few ops. |
Thanks @trevor-m Merged. |